I was opening the Manage Assistive Technology Versions disclosure on the Test Queue page to add/edit AT verions. Found that if I hit ESC on my keyboard to close either modals, an error is thrown which reads onHide is not a function where the stacktrace points to a line inside react-bootstrap's Modal component. Screenshot:
I confirmed this doesn't happen on production so my only guess is this error was introduced in #1148 when react-bootstrap was bumped from 2.7.0 to 2.10.4. Although, nothing obvious jumps out at me when viewing the release notes.
This PR should restore the functionality that's on production (although I'm also wondering if the title refocus instead of closing the modal is intentional).
I was opening the
Manage Assistive Technology Versionsdisclosure on the Test Queue page to add/edit AT verions. Found that if I hitESCon my keyboard to close either modals, an error is thrown which readsonHide is not a functionwhere the stacktrace points to a line insidereact-bootstrap's Modal component. Screenshot:I confirmed this doesn't happen on production so my only guess is this error was introduced in #1148 when
react-bootstrapwas bumped from2.7.0to2.10.4. Although, nothing obvious jumps out at me when viewing the release notes.This PR should restore the functionality that's on production (although I'm also wondering if the title refocus instead of closing the modal is intentional).