search

w3c / aria-at-app

Test runner and results reporter for ARIA-AT
http://aria-at.w3.org/
Other
36 stars 15 forks source link

Toggle button report data was not preserved when advancing v2024.10.22 to draft #1260

Closed mcking65 closed 2 weeks ago

mcking65 commented 4 weeks ago

I just advanced V2024.10.22 of toggle button to draft and the report status is that none of the required reports are started. None of the prior report data was copied in. I was expecting all of it.

This is in contrast with v2024.10.22 of the radio group test plan. Just before advancing the toggle plan, I advanced the radio plan to draft review, and all the data that should have been preserved was preserved. There were 4 tests for NVDA where the changes caused data to be dropped, and that was expected. the JAWS and VoiceOver reports for radio group were fully preserved.

howard-e commented 3 weeks ago

This is in contrast with v2024.10.22 of the radio group test plan. Just before advancing the toggle plan, I advanced the radio plan to draft review, and all the data that should have been preserved was preserved. There were 4 tests for NVDA where the changes caused data to be dropped, and that was expected. the JAWS and VoiceOver reports for radio group were fully preserved.

The difference between the 2 is that the refIds were updated for toggle button but that change wasn't being ignored during the results copy process. #1261 should address it.

When this lands production, the results can still be immediately copied by attempting to create the test plan reports matching the combinations from the old toggle button test plan version. A modal will pop up asking if you'd like to create an empty report or copy over the old results.

howard-e commented 3 weeks ago

This fix is now live.

When this lands production, the results can still be immediately copied by attempting to create the test plan reports matching the combinations from the old toggle button test plan version. A modal will pop up asking if you'd like to create an empty report or copy over the old results.

@mcking65 would you like me to go ahead and do the above?

mcking65 commented 2 weeks ago

Thank you @howard-e for quickly deploying a fix!! I successfully advanced the latest version of the toggle button plan into candidate review.