w3c / aria-at

Assistive Technology ARIA Experience Assessment
https://aria-at.netlify.app
Other
154 stars 28 forks source link

Radio buttons for assertion verdicts #1090

Closed stalgiag closed 4 months ago

stalgiag commented 4 months ago

Preview Tests

This PR replaces the checkbox with "yes" & "no" radio buttons in the assertion verdict form fields. This is part of the work of addressing aria-at-ap/#1045. The related app change is aria-at-app/#1161.

Note that nested fieldset was used as it matched other UI in the form. In my testing, both screen and screenreader, this proved usable but I am open to other structures.

Now both assertion.passed and assertion.result are Boolean | null. The result can technically be a string because of the legacy failedReason which no current form uses. I did not remove the code associated with this. This is also why result has been kept instead of being removed entirely.