Leaving in Draftto indicate that this should be merged with caution only after the related changes are ready to be deployed on the app side. Reviewers can switch to Ready for Review once they have acknowledged that it is necessary to time these merges carefully. Thank you!
This PR replaces the checkbox with "yes" & "no" radio buttons in the assertion verdict form fields. This is part of the work of addressing aria-at-ap/#1045. The related app change is aria-at-app/#1161.
Note that nested fieldset was used as it matched other UI in the form. In my testing, both screen and screenreader, this proved usable but I am open to other structures.
Now both assertion.passed and assertion.result are Boolean | null. The result can technically be a string because of the legacy failedReason which no current form uses. I did not remove the code associated with this. This is also why result has been kept instead of being removed entirely.
Preview Tests
Reopening after #1090 was merged prematurely
Leaving in
Draftto indicate that this should be merged with caution only after the related changes are ready to be deployed on the app side. Reviewers can switch toReady for Reviewonce they have acknowledged that it is necessary to time these merges carefully. Thank you!Preview Tests
This PR replaces the checkbox with "yes" & "no" radio buttons in the assertion verdict form fields. This is part of the work of addressing aria-at-ap/#1045. The related app change is aria-at-app/#1161.
Note that nested fieldset was used as it matched other UI in the form. In my testing, both screen and screenreader, this proved usable but I am open to other structures.
Now both
assertion.passedandassertion.resultareBoolean | null. Theresultcan technically be a string because of the legacyfailedReasonwhich no current form uses. I did not remove the code associated with this. This is also whyresulthas been kept instead of being removed entirely.