search

w3c / aria-at

Assistive Technology ARIA Experience Assessment
https://aria-at.netlify.app
Other
154 stars 28 forks source link

GitHub teams for signup and authentication in test runner #167

Open zcorpan opened 4 years ago

zcorpan commented 4 years ago

We're planning to use a github teams and github authentication as the signup and login flow for running aria-at tests in the new runner. For now, we can manually add members in GitHub's UI.

There are two aria-at teams in the w3c org: aria-at and aria-at-editors. We could use these teams for testers and admins in the test runner, I think. Or is there a reason it would be good to add new teams specifically for the runner?

I would like to have "maintainer" permissions for at least the team we decide to use for testers, so I can invite users to that team. The pilot test and usability tests are planned to take place the week of May 11.

zcorpan commented 4 years ago

@jnurthen and @mcking65 are maintainers currently in the aria-at team. Can you add me as a maintainer as well?

michael-n-cooper commented 4 years ago

I presumed Matt's consent and made Simon a maintainer of the aria-at team. If you find a need to set up additional teams just let me know.

zcorpan commented 4 years ago

Thanks!

zcorpan commented 4 years ago

@michael-n-cooper So, as a stop-gap, we used teams in Bocoup org, but we should have the teams in the w3c org. I now think the teams for the app should be separate to the current aria-at and aria-at-editors teams for clarify. We also have both production and staging for the app with different teams.

Please create these teams in the w3c org:

Please add the following people with Maintainer role to all those teams:

(or only add me and I can add the others)

Time sensitivity: ASAP, but Sunday this week at the latest. Apologies for late notice.

Thank you!

michael-n-cooper commented 4 years ago

Got those four teams set up, and all those people added to each team with maintainer access. In addition:

Let me know if you need any of those settings tweaked.

zcorpan commented 4 years ago

They don't need any particular GitHub access, but it's OK for the "aria-at-app admin" team to have it.

Thank you!

spectranaut commented 4 years ago

I just tried to add the testers from the bocoup team to the w3c team, but I couldn't for most testers. When trying to add a tester (such as jscholes) I'd get the message: Not a member of this organization.

When I added rwaldron, I was told Through this team, this member will receive access to one repository: w3c/aria-at

Is it possible that the testers cannot be added to this team because they need to be in the w3c organization in order to be give access to w3c/aria-at repo? Do testers need to have access to w3c/aria-at repo? If so, we will need to add all testers to the w3c organization.

michael-n-cooper commented 4 years ago

Yes, sorry, I didn't think to warn you of that. For each GitHub organization (in this case w3c), somebody with owner access has to invite people into the organization before they can be added to teams. Once they've joined the organization, team maintainers can add them to any team and that organization subsequently.

What usually works best is just to send me the usernames of people you want to add, and the team(s) you want them added to. I'll add them, which will cause an invite to be sent, once they accept the invite they will be part of the team. In theory it's also possible for me to add them to the organization (same invite process) and leave the team assignments to you, though we've found the process more ambiguous in the past. Either way, send me the info and I'll add them.

spectranaut commented 4 years ago

Thanks @michael-n-cooper I'll send you an email!

alflennik commented 3 years ago

@michael-n-cooper Hi Michael, I'm the latest member of Bocoup's ARIA-AT team 😀

Could you add me as member of the w3c organization and invite me to the ARIA-AT team?

alflennik commented 1 year ago

@michael-n-cooper Hi Michael, could you add @aleenaloves as a member of the w3c organization? She will be joining the ARIA-AT team 🙂

Also, could you add me as a maintainer on the ARIA-AT team? Bocoup's current maintainers, Seth and Simon, have both moved onto other opportunities and we'd like to keep the ability to add and remove members to the team! Thanks!

michael-n-cooper commented 1 year ago

Hi @alflennik I've made you a maintainer and invited @aleenaloves to the team.

alflennik commented 1 year ago

Hi @michael-n-cooper our team is growing: could you add @paul-clue and @ccanash to the W3C org and the github team? Thank you!

michael-n-cooper commented 1 year ago

Hi @alflennik I've sent @Paul-Clue and @ccanash invites to the aria-at team.