search

w3c / aria-at

Assistive Technology ARIA Experience Assessment
https://aria-at.netlify.app
Other
154 stars 28 forks source link

Feedback: "Close a modal dialog in interaction mode" (Modal Dialog Example, Test 5) #720

Closed jha11y closed 5 months ago

jha11y commented 2 years ago

Description of Behavior

Test Setup

Review Conflicts for "Close a modal dialog in interaction mode"

  1. Unexpected Behaviors for "Escape" Command

    • Tester jha11y recorded output "None unless escape is hit twice, then: button unavailable Run Test Setup Add Delivery Address button " and noted "Output is excessively verbose, e.g., includes redundant and/or irrelevant speech".
    • Tester IsaDC recorded output """" and noted no unexpected behavior.
    • Tester louis4533 recorded output "Add Delivery Address button " and noted "I had to press escape twice. Once to exit focus mode, and a 2nd time to close the dialog.".

  2. Assertion Results for "Escape" Command and "Role 'button' is conveyed" Assertion

    • Tester jha11y recorded output "None unless escape is hit twice, then: button unavailable Run Test Setup Add Delivery Address button " and marked assertion as passing.
    • Tester IsaDC recorded output """" and marked assertion as failing with no output.
    • Tester louis4533 recorded output "Add Delivery Address button " and marked assertion as passing.

  3. Assertion Results for "Escape" Command and "Name 'Add Delivery Address' is conveyed" Assertion

    • Tester jha11y recorded output "None unless escape is hit twice, then: button unavailable Run Test Setup Add Delivery Address button " and marked assertion as passing.
    • Tester IsaDC recorded output """" and marked assertion as failing with no output.
    • Tester louis4533 recorded output "Add Delivery Address button " and marked assertion as passing.
jha11y commented 2 years ago

The test case #4 for the modal dialog (Testing Task: Close a modal dialog in interaction mode) is flawed. A user can get different results depending on how many times they hit the escape key. Also, for this test when activating the "Run Test Setup" button, the dialog automatically opens. This is different behavior from tasks #1 and #2, but the same as #3. The inconsistency between tasks is very confusing.

IsaDC commented 2 years ago

@jha11y The Community Group has previously reached consensus that in interaction mode, a screen reader should pass the Escape key through to the page. I know that this can be seen as subjective, but the test was written with this decision in mind. As such, please rerun the test, pressing Escape only once as instructed. If the results do not pass the assertions (which we know they wont), mark the assertions as failing.

Note: there is a chance that if/when these tests are reviewed by NVAccess during a future phase, they will disagree with the test as it is currently written. If so, this decision may need to be revisited.

jha11y commented 2 years ago

@IsaDC I fine with that. I can update my results

mcking65 commented 5 months ago

Out-of-date due to test plan refactor