search

w3c / aria-common

Shared files for the ARIA repositories
Other
8 stars 15 forks source link

[aria.js]: "abstract role" not added to index #105

Open pkra opened 9 months ago

pkra commented 9 months ago

The issue https://github.com/w3c/aria/issues/2082 made me look at https://w3c.github.io/aria/#role_definitions

While the line

https://github.com/w3c/aria-common/blob/2fe4fe20cffad6314bddb6d6b9ed09c63c087cfb/script/aria.js#L265C6-L265C6

suggests we add a parenthetical "abstract role", this appears to be broken, i.e., none of the abstract roles have this parenthetical.

pkra commented 9 months ago

Related to #104.

I'm getting the feeling that the current approach to generate our abstracted data by looking at innerHTML or innerText for various elements might be something worth discussing.

pkra commented 9 months ago

For completeness: this is already "broken" in the 1.2 REC.

pkra commented 9 months ago

While working on #106, I found the bug: aria.js uses querySelectorAll instead of querySelector here:

https://github.com/w3c/aria-common/blob/2fe4fe20cffad6314bddb6d6b9ed09c63c087cfb/script/aria.js#L241-L245

so the if-check immediately after will always fail.

pkra commented 9 months ago

However, besides obviously introducing many changes, it seems to break a lot of things (tbd exactly how).