search

w3c / aria-common

Shared files for the ARIA repositories
Other
8 stars 15 forks source link

Fix "Platform Mapping Maintainers" transformation for AAMs #26

Closed joanmarie closed 5 years ago

joanmarie commented 5 years ago

The transformation of "Authors" to "Platform Mapping Maintainers" is done by finding the dt element in the head and matching on the string "Authors:". Due to some change somewhere (perhaps ReSpec), the "Authors:" string is now surrounded by whitespace. Trimming the whitespace before doing the string comparison fixes the problem.

Addresses github issue #25

joanmarie commented 5 years ago

@michael-n-cooper Please review. Thanks!

joanmarie commented 5 years ago

@michael-n-cooper: It looks like you merged this into Core-AAM (so the bug is now fixed), but I don't see it merged here. Is that intentional?

michael-n-cooper commented 5 years ago

Looks like branch restriction for aria-common wasn't working properly. I've changed that; will come back to this specific pull request when I have more concentration energy.

joanmarie commented 5 years ago

Looks like branch restriction for aria-common wasn't working properly. I've changed that; will come back to this specific pull request when I have more concentration energy.

How are your energy levels? :smile: When you look at the change you will see it's a one line change and all it does is trim whitespace so the comparison once again works. Thanks!

michael-n-cooper commented 5 years ago

Sorry this shouldda been fast for me to review, I just couldn't handle looking at code at the time! Merged now.