search

w3c / aria-common

Shared files for the ARIA repositories
Other
8 stars 15 forks source link

Improve automation #37

Closed carmacleod closed 4 years ago

carmacleod commented 4 years ago

For background, please follow this circular thread that occurred after https://github.com/w3c/aria/pull/1165 was merged:

Can we create some kind of bot account for making those automatic commits, so that there's a hint where to look when things go wrong?

Also, if there's conflicts, maybe the copy can fail and ping somebody? It was just a fluke that I happened to look at the live region definition and notice the Ajax back in there AND it was recent enough that I remembered making the change... I wonder if other changes have been overwritten at some point and nobody noticed.

jnurthen commented 4 years ago

To be honest that is my job and I failed here. I normally will notice if a PR includes changes to aria-common and resolve the issues at that point. It may be a better use of time to add automation to fail (or at least add a warning) to a PR if it changes anything in aria-common.

carmacleod commented 4 years ago

That makes sense - catch it at the source. Good idea.

carmacleod commented 4 years ago

Shall I open an issue in the aria repo to automate making sure a PR does not have any changes in aria/common and close this issue?

carmacleod commented 4 years ago

Opened https://github.com/w3c/aria/issues/1228.