search

w3c / aria-common

Shared files for the ARIA repositories
Other
8 stars 15 forks source link

fix: Single quote for Action condition #67

Closed nschonni closed 2 years ago

nschonni commented 3 years ago

There was an error on the run https://github.com/w3c/aria-common/actions/runs/789298898

The workflow is not valid. .github/workflows/deploy.yml (Line: 22, Col: 9): Unexpected symbol: '"w3c/aria-common"'. Located at position 22 within expression: github.repository == "w3c/aria-common"

So I'm seeing if it just didn't like the if: syntax

nschonni commented 3 years ago

Looks like it's actually the quotes https://github.com/actions/runner/issues/866

nschonni commented 3 years ago

@michael-n-cooper @zcorpan sorry, I hadn't hit this but before

nschonni commented 3 years ago

@michael-n-cooper @zcorpan ping

zcorpan commented 2 years ago

What difference do the ${{ and }} make?

nschonni commented 2 years ago

What difference do the ${{ and }} make?

That is for an explicit interpolation of the string, but there is an implicit one for the if: already