Fix auto exporting and add missing IDs back to mapping tables

w3c / aria-common

Shared files for the ARIA repositories

Other

8 stars 15 forks source link

Fix auto exporting and add missing IDs back to mapping tables #80

Closed spectranaut closed 2 years ago

spectranaut commented 2 years ago

This is regard to: https://github.com/w3c/core-aam/issues/102 PR reviewed originally here: https://github.com/w3c/core-aam/pull/105

Changes:

Table ids are back!
The "saved"/"exported" spec to use the summary details instead of the table.
Removed the dependencies on respec events as in the issue it was discussed repub no longer publishes events. It turns out that the "mappingTables" function is called during respect "preprocessing" (as was configured in the preProcess parameter in the respecConfig), so once i removed the respec events code -- which was causing an error -- the tables showed up twice (as mappingTables was run twice, once during preprocessing and once when mapping-tables.js was loaded).
@michael-n-cooper fixed a bug in the show/hide columns buttons in the table view

spectranaut commented 2 years ago

Hi @michael-n-cooper if you are good with this change can you merge? :) James will be out for the next week.

spectranaut commented 2 years ago

maybe @jnurthen is back from vacation? :)

jnurthen commented 2 years ago

crossing fingers

stevefaulkner commented 2 years ago

Table ids are back!

thanks for fixing this, has been annoying me ;-)

jnurthen commented 2 years ago

Is it working. It is not for me right now.

From: Steve Faulkner @.> Sent: Wednesday, March 2, 2022 2:37:12 PM To: w3c/aria-common @.> Cc: James Nurthen @.>; State change @.> Subject: Re: [w3c/aria-common] Fix auto exporting and add missing IDs back to mapping tables (PR #80)

Table ids are back!

thanks for fixing this, has been annoying me ;-)

— Reply to this email directly, view it on GitHubhttps://github.com/w3c/aria-common/pull/80#issuecomment-1057463767, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANFAP4KM4H7HNRCR5UWTZ3U57URRANCNFSM5OVNBNGA. You are receiving this because you modified the open/close state.Message ID: @.***>

stevefaulkner commented 2 years ago

@jnurthen i am still seeing <summary id=""> in html-aam

jnurthen commented 2 years ago

Not surprising in html-aam as that isn't using the common version right now.

It is still broken in core-aam for me though. Looking into it.

spectranaut commented 2 years ago

I can look at it tomorrow if you don't get any where @jnurthen!

jnurthen commented 2 years ago

I'm making progress... give me another day or so.