search

w3c / aria-practices

WAI-ARIA Authoring Practices Guide (APG)
https://www.w3.org/wai/aria/apg/
Other
1.21k stars 345 forks source link

Template for pull requests #1210

Open spectranaut opened 5 years ago

spectranaut commented 5 years ago

We can provide GitHub with a template for new pull requests to help with the new review process. The template is a markdown file we would have to check into the project (for example, in .github/PULL_REQUEST_TEMPLATE.md).

To begin, we'd like something like the following. Any thing else we should add to it?

### Review checklist

Note: If your PR does not cover one of the following areas, delete the line.

* [ ] [Editorial review](https://github.com/w3c/aria-practices/wiki/Pull-Request-Review-Process#editorial_review) by reviewer_id
* [ ] [Functional review](https://github.com/w3c/aria-practices/wiki/Pull-Request-Review-Process#functional_review) by reviewer_id
* [ ] [Visual design review](https://github.com/w3c/aria-practices/wiki/Pull-Request-Review-Process#design_review) by reviewer_id
* [ ] [Accessibility review](https://github.com/w3c/aria-practices/wiki/Pull-Request-Review-Process#accessibility_review) by reviewer_id
* [ ] [Code review](https://github.com/w3c/aria-practices/wiki/Pull-Request-Review-Process#code_review) by reviewer_id
* [ ] [Test review](https://github.com/w3c/aria-practices/wiki/Pull-Request-Review-Process#test_review) by reviewer_id
ZoeBijl commented 5 years ago

Thank you this looks good. Is there anything we need to do before we can put this to use?