search

w3c / aria-practices

WAI-ARIA Authoring Practices Guide (APG)
https://www.w3.org/wai/aria/apg/
Other
1.21k stars 345 forks source link

An in-range update of vnu-jar is breaking the build 🚨 #1346

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

The devDependency vnu-jar was updated from 20.2.25 to 20.2.28.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

vnu-jar is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **Travis CI - Branch:** The build **failed**.
Commits

The new version differs by 16 commits.

  • 5eba223 Update changelog
  • 2d2de4f Align ARIA role checking w/ current HTML-ARIA spec
  • df5df6a Update ARIA checking for select/option/optgroup
  • 749f54a Drop warning about browser support for role=none
  • ea93dcb Add proper ARIA checking for the element
  • af7c795 Align input-element checking w/ current HTML-ARIA
  • 77584c4 Align alt-less img checking w/ current HTML-ARIA
  • 2d78043 Align img ARIA role checking with current spec
  • 50cd86d Handle all img[alt] combinations for ARIA checking
  • 6d9ef21 Allow SVG feDropShadow element (Filter Effects)
  • 89a1221 Allow heading content within legend element
  • d375c0f Refine autocomplete checking to align with spec
  • ce09118 Allow generator-unable-to-provide-required-alt
  • 9bbe0aa Allow "onslotchange" global attribute
  • 777bc19 Align allowed event-handler attributes with spec

There are 16 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 20.2.25 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

nschonni commented 4 years ago

The error messages from the build

"file:/home/travis/build/w3c/aria-practices/examples/slider/multithumb-slider.html":57.19-66.54: error: Element “img” is missing required attribute “alt”.

"file:/home/travis/build/w3c/aria-practices/examples/slider/multithumb-slider.html":67.19-76.54: error: Element “img” is missing required attribute “alt”.

"file:/home/travis/build/w3c/aria-practices/examples/slider/multithumb-slider.html":88.17-95.54: error: Element “img” is missing required attribute “alt”.

"file:/home/travis/build/w3c/aria-practices/examples/slider/multithumb-slider.html":96.17-104.52: error: Element “img” is missing required attribute “alt”.

It may just be an updated error message since it looks like it was already suppressed https://github.com/w3c/aria-practices/blob/b543058379f8180be0c76fca7b52f7fc2ec41ad8/.vnurc#L7

greenkeeper[bot] commented 4 years ago

Your tests are still failing with this version. Compare changes

Release Notes for 16 March 2020

First release in more than one year. This release provides a number of improvements in ARIA role checking and in CSS checking, as well as support for checking a number of HTML features that weren’t supported previously. It’s the first release to provide binary runtime images, as an alternative to the jar/war distributions. It's also the last release for which the Web-based checker will be configured to listen on all interfaces; after this release, the checker will bind by default to 127.0.0.1 — so to make the checker listen on a different address, you’ll need to specify an exact address.

More: https://github.com/validator/validator/blob/master/CHANGELOG.md#20316

The files in this release provide a portable standalone version of the Nu Html Checker in a number different forms: as a Java jar file, as a Java war file, and as binary runtime images that can be used even on a system that doesn’t have Java installed.

Use the binary images and jar file either for batch checking of documents from the command line and other scripts/apps, as documented at https://validator.github.io/validator/, or as a self-contained service for browser-based checking of HTML documents over the Web—similar to https://validator.w3.org/nu/.

Use the war file to deploy the Nu Html Checker through a servlet container such as Tomcat, as documented at https://validator.github.io/validator/#servlet.

Commits

The new version differs by 16 commits.

  • 48490ce Prepare the 20.3.16 release.
  • 2d28cc5 Allow 'allow-downloads' in iframe[sandbox]
  • 4430974 Travis: (Re)add release uploads for OSX binaries
  • 7296bdb Update htmlparser
  • 98480d7 Refine autocomplete checking further to match spec
  • 99edc79 Restrict aria-dropeffect to specified values
  • ad3e5c8 Update css-validator
  • 522d3a4 Add workaround to allow newlines in CSP policies
  • 34f2044 Travis: Don’t specify JDK version for OSX build
  • 10bebfd Travis: Ensure JAVA_HOME gets set for OSX build
  • d048e3d Ensure CSS errors don’t end with multiple periods
  • 45a89bb Allow any value for aria-dropeffect
  • 27ec6de chore: Flatten Python variables
  • 11f052b chore: Flatten TRAVIS_TAG indirection
  • d4a206f chore: Pull Tomcat install into install block

There are 16 commits in total.

See the full diff