Open ariellalgilmore opened 3 weeks ago
@mcking65 this is not ideal code, but I tweaked some files and updated, so that the deploy preview now shows the open in codePen button inside the HTML source code section for this example only! Just wanted to get some feedback first before making more permenent changes
@ariellalgilmore
I made some changes. My understanding of the discussion is that we keep the display but just make the changes I described in the revised top comment in this PR.
I'd like to suggest just one modification to the DOM order. Currently the open in codepen button in the HTML source section is appearing after the screen reader separator <div role="separator"...
. It would be better if it were placed between the paragraph and the separator like in the example section where the button is between the heading and the separator.
Thanks @mcking65 for the updates! Keeping the html source code with the button looks good. I updated the dom order so that the button goes after the paragraph but before the separator
The ARIA Authoring Practices (APG) Task Force just discussed Change to HTML source section on example pages
.
The ARIA Authoring Practices (APG) Task Force just discussed Change to HTML source section on example pages
.
Resolve issue #3027 with the following changes:
Preview
Preview revised combobox example page in compare branch
Review checklist
Reviewers: To learn what needs to be covered by each review, Follow the link for the type of review to which you are assigned.
WAI Preview Link (Last built on Tue, 25 Jun 2024 20:45:06 GMT).