Closed stalgiag closed 4 months ago
@mcking65 @a11ydoer could you also review this work on the deploy preview's patterns page?
This is great, really looks good to me! Thanks for tackling this task. I only have a few comments:
- The suggestion for an accessible h2 from this comment and this comment are missing. Could those still be added?
- When doing a search with no valid results, I'd prefer some indication of that be shown, eg. No results found or similar. What do you think? I've attached a screenshot below which just shows a blank area
Nice call. Didn't notice those comments, too focused on the mockup. Also agree with the need for a "no results" element.
First handled by 4b0a408 & 5626c7b and accompanying build repo commits.
Second addressed in eaf3f2deaf3f2d and accompanying build repo commits.
The ARIA Authoring Practices (APG) Task Force just discussed New patterns page filter
.
Updates based on @isaacdurazo 's mockups from the feedback in the APG Task Force meeting:
cc @a11ydoer @mcking65 this should be ready for your review again
@a11ydoer if you agree it is ready to ship, I will merge.
@stalgiag thank you for all the work on this! We finally have this long-awaited feature!
see #2534
This PR adds an input to the patterns index page that filters the patterns as you type. Additionally, a toggle is added that allows users to switch between a list and a grid view for the patterns.
Build repo PR
View an example of this at Build repo's netlify preview provided link. This WAI Preview link will fail to build until wai-aria-practices#1234 is also merged
WAI Preview Link (Last built on Tue, 02 Jul 2024 22:32:14 GMT).