search

w3c / aria-practices

WAI-ARIA Authoring Practices Guide (APG)
https://www.w3.org/wai/aria/apg/
Other
1.21k stars 346 forks source link

Scrollable Listbox Example: Ad default value 'None' so first item can be focusable on load #3139

Closed wagnermaciel closed 2 days ago

wagnermaciel commented 1 month ago

Fixes https://github.com/w3c/aria-practices/issues/3138

Preview

Preview changes to Scrollable Listbox Example in compare branch

Review checklist

Reviewers: To learn what needs to be covered by each review, Follow the link for the type of review to which you are assigned.

Not applicable:

WAI Preview Link (Last built on Wed, 06 Nov 2024 01:45:17 GMT).

css-meeting-bot commented 3 weeks ago

The ARIA Authoring Practices (APG) Task Force just discussed PR 3139 - Scrollable listbox fix.

The full IRC log of that discussion <Jem> Topic: PR 3139 - Scrollable listbox fix
<Jem> github:https://github.com/w3c/aria-practices/pull/3139
<Jem> mck: This is ready to review and added the checklist
<Jem> ..it touches only two files, html and js
<Jem> arie: one testing failed, snapshot issue.
<Jem> jem: assertion error for aria-selected.
<Jem> jon will do code and testing review
css-meeting-bot commented 1 week ago

The ARIA Authoring Practices (APG) Task Force just discussed PR 3139 - Scrollable listbox fix.

The full IRC log of that discussion <jugglinmike> Topic: PR 3139 - Scrollable listbox fix
<jugglinmike> github: https://github.com/w3c/aria-practices/pull/3139
<jugglinmike> Matt_King: jongund requested a change from the author, and it looks like they made that change
<jugglinmike> Matt_King: And all the tests pass
<jugglinmike> jongund: I have reviewed their work since they made the changes, so it looks good to me, now
<jugglinmike> jongund: I was doing code review and test review
<jugglinmike> Matt_King: I think this is now just waiting on me. I'll review it, and if it's looking good, then it'll get merged!