search

w3c / aria-practices

WAI-ARIA Authoring Practices Guide (APG)
https://www.w3.org/wai/aria/apg/
Other
1.21k stars 347 forks source link

Review Feed Pattern #560

Open mcking65 opened 6 years ago

mcking65 commented 6 years ago

The feed pattern developed for issue #245 is ready for review.

Task Force Reviews Requested as of December 1, 2017

annabbott commented 6 years ago

WAI-ARIA Roles, States, and Properties > fifth bullet: Typo: "It is optional but strongly recommended for Each article element" Lower case the 'e' in 'each'.

annabbott commented 6 years ago

No other issues noted.

annabbott commented 6 years ago

I'm guessing that the example review will be opened as a separate issue?

mcking65 commented 6 years ago

@annabbott commented:

WAI-ARIA Roles, States, and Properties > fifth bullet: Typo: "It is optional but strongly recommended for Each article element" Lower case the 'e' in 'each'.

Fixed in commit 200afa4.

I'm guessing that the example review will be opened as a separate issue?

Yes. But, I will be postponing that review and discussion off to the next APG release and marking the current implementation as a proposed implementation that does not yet have task force consensus.

sh0ji commented 6 years ago
  1. In the context of a feed, the web page code is responsible for:

In this item, "web page code" seems ambiguous, like we're shifting blame to the code rather than the author. I'd prefer "web page author," which does appear elsewhere in the document, including the final paragraph of the feed description.

No other issues.

mendeza commented 7 months ago

Hi @mcking65. Thank you so much for the Feed Pattern, it's lovely. I have a question about adding the Ctrl- modifer to the Home and End keys, e.g., in your document here.

I surveyed the other APG patterns (listed after this paragraph) and found considerable use of Navigation keys. In many cases Home and End are left unmodified. Do you have a strong rationale for using modifiers in the Feed Example, or would you advise leeway and not object to unmodified use? Many thanks for your guidance.

  1. https://www.w3.org/WAI/ARIA/apg/patterns/accordion/ — Home, End
  2. https://www.w3.org/WAI/ARIA/apg/patterns/carousel/examples/carousel-2-tablist/ — Home, End
  3. https://www.w3.org/WAI/ARIA/apg/patterns/combobox/ — Home, End
  4. https://www.w3.org/WAI/ARIA/apg/patterns/feed/ — CTRL+Home, CTRL+End, PageUp, PageDown
  5. https://www.w3.org/WAI/ARIA/apg/patterns/grid/ — Home, End, CTRL+Home, CTRL+End, PageUp, PageDown
  6. https://www.w3.org/WAI/ARIA/apg/patterns/listbox/ — CTRL+Home, CTRL+End, CTRL+SHIFT+Home, CTRL+SHIFT+End
  7. https://www.w3.org/WAI/ARIA/apg/patterns/menubar/ — Home, End
  8. https://www.w3.org/WAI/ARIA/apg/patterns/slider-multithumb/examples/slider-multithumb/ — Home, End, PageUp, PageDown
  9. https://www.w3.org/WAI/ARIA/apg/patterns/slider/ — Home, End, PageUp, PageDown
  10. https://www.w3.org/WAI/ARIA/apg/patterns/spinbutton/ — Home, End, PageUp, PageDown
  11. https://www.w3.org/WAI/ARIA/apg/patterns/tabs/ — Home, End
  12. https://www.w3.org/WAI/ARIA/apg/patterns/toolbar/ — Home, End
  13. https://www.w3.org/WAI/ARIA/apg/patterns/treegrid/ — Home, End, CTRL+Home, CTRL+End, PageUp, PageDown
  14. https://www.w3.org/WAI/ARIA/apg/patterns/treeview/ — Home, End, CTRL+SHIFT+Home, CTRL+SHIFT+End
  15. https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/ — Home, End
mcking65 commented 7 months ago

@mendeza asks:

Do you have a strong rationale for using modifiers in the Feed Example, or would you advise leeway and not object to unmodified use? Many thanks for your guidance.

The recommendations for keyboard commands intend to reflect similar conventions. Typically, unmodified home/end stay within a narrowly scoped context where as when modified by control, they make a larger change within the context. For example:

In the context of feed, ctrl+home and ctrl+end are more akin to moving to top of doc and bottom of doc than start of line and end of line. That leaves options for home and end to be used within a smaller context, e.g., start of article and end of article, which are commands we did not define. As a new pattern with no precedent in native Windows, macOS, or Linux, the feed pattern is still somewhat a solution in incubation. That is part of the rationale for keeping this issue open for feedback and questions.