Insertions and deletions in PR diff preview are unreadable in dark mode

w3c / aria

Accessible Rich Internet Applications (WAI-ARIA)

https://w3c.github.io/aria/

Other

624 stars 118 forks source link

Insertions and deletions in PR diff preview are unreadable in dark mode #2133

Open adampage opened 3 months ago

adampage commented 3 months ago

I’m not sure this is the proper home for this issue, but I just noticed that the color styles for the ins and del elements in our PR diff previews make their text unreadable if your OS environment is in dark mode.

A video capture demonstrating how the colors for ins and del elements in htmldiff’d W3C documents become unreadable in dark mode

I tracked this back to issue w3c/htmldiff-ui#12, where @tabatkins says:

...The answer is to make your documents darkmode-aware...

Is that something we can/should do for our documents?

daniel-montalvo commented 3 months ago

@adampage Thanks for bringing this to our attention

Hopefully this is soon addressed in respec Ref: https://github.com/w3c/respec/issues/2651