search

w3c / aria

Accessible Rich Internet Applications (WAI-ARIA)
https://w3c.github.io/aria/
Other
654 stars 125 forks source link

Netlify deploy preview always builds the main spec, even when the PR changes a different spec in the monorepo #2285

Closed cookiecrook closed 4 months ago

cookiecrook commented 4 months ago

Netlify deploy preview always builds the main spec, even when the PR changes a different spec in the monorepo

I noticed in Core-AAM PR #2284 that the deploy preview built the main ARIA spec. I expect we'd prefer to see the Core-AAM spec in this case, since that's what changed in the PR.

pkra commented 4 months ago

All specs are built in every netlify preview - we just haven't worked out adding links yet (#2242 is tracking that).

Just extend the path, e.g., https://deploy-preview-2284--wai-aria.netlify.app/core-aam/.

spectranaut commented 4 months ago

closing as duplicate of #2242

daniel-montalvo commented 4 months ago

@cookiecrook and others.

Currently you can still get to the relevant preview by adding /spec-shortname/ to the end of the base URI.

You could have https://deploy-preview-2284--wai-aria.netlify.app/core-aam/ and that'll take you to the ore-AAM version of that PR.

I'm still figuring out a way to customize Netlify PR comments to explicitly list all spec preview URIs.

rahimabdi commented 4 months ago

You can also check the spec preview using the "Checks" tab within the PR (it shows up in the "Netlify" section-> "Pages changed - wai-aria").