Make aria-relevant and ariaRelevant reflect

sideshowbarker commented 2 months ago

The ariaRelevant IDL attribute seems to have been intentionally commented out from the ARIAMixin interface in https://github.com/w3c/aria/commit/646f093848a1943c8343f34ad80f72dbd78f54e6 — without any explanation that I could find, including not in the related issue at https://github.com/w3c/aria/issues/1058.

But since at https://w3c.github.io/aria/#idl-reflection-attribute-values the spec says:

All ARIA attributes reflect in IDL as nullable DOMString attributes.

…and since there’s a test case included in http://wpt.live/html/dom/aria-attribute-reflection.html, and WebKit, Gecko, and Blink all pass that test — then it seems ariaRelevant needs to be included in ARIAMixin in the spec.

[x] "author MUST" tests: N/A
[x] "user agent MUST" tests: http://wpt.live/html/dom/aria-attribute-reflection.html
[x] Browser implementations (link to issue or commit):
- WebKit: Already implemented to reflect
- Gecko: Already implemented to reflect
- Blink: Already implemented to reflect
[ ] Does this need AT implementations?
[ ] Related APG Issue/PR:
[ ] MDN Issue/PR:

Preview | Diff

netlify[bot] commented 2 months ago

Deploy Preview for wai-aria ready!

Name	Link
Latest commit	33712f97a5c74c977b3cf0ab8d04ea96eed3a5b3
Latest deploy log	https://app.netlify.com/sites/wai-aria/deploys/66d3da647e8f8e000846b27c
Deploy Preview	https://deploy-preview-2326--wai-aria.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

w3cbot commented 2 months ago

sideshowbarker marked as non substantive for IPR from ash-nazg.

rahimabdi commented 2 months ago

Thank you for raising this, @sideshowbarker!

In addition to the WPT test confirming reflection, I am indeed seeing ariaRelevant in the accessibility WebIDL definition files for the 3 major browsers:

@cookiecrook had raised a newer related issue describing the general challenges with reflecting this attribute which was why it was removed: https://github.com/w3c/aria/issues/1267.

I'll assign this one to myself to discuss at a future ARIA WG meeting.

spectranaut commented 2 months ago

Discussed today's aria working group meeting during triage: https://www.w3.org/2024/09/05-aria-minutes#t02

cookiecrook commented 2 months ago

I am indeed seeing ariaRelevant in the accessibility WebIDL definition files for the 3 major browsers

Yes, since this reflects the current reality, let's approve it.... In the meeting this morning I suggested, "revisit after the ongoing IDL discussions resolve," (so @spectranaut added the Do Not Merge label) but since all 3 engines are already shipping it, this is okay to merge as-is, IMO.

rahimabdi commented 2 months ago

I think the table in Section 10.2 ARIA Attribute Correspondence also needs updating.

w3c / aria