search

w3c / aria

Accessible Rich Internet Applications (WAI-ARIA)
https://w3c.github.io/aria/
Other
654 stars 125 forks source link

Update: fix inconsistency around aria-setsize=-1 #2341

Open scottaohara opened 1 month ago

scottaohara commented 1 month ago

closes #1759 closes https://github.com/w3c/aria/issues/2346 also closes https://github.com/w3c/core-aam/issues/149

This PR adjusts the requirements for aria-setsize to fix the inconsistency between the ARIA and CORE AAM specs regarding the use of -1 as a value.

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

Preview | Diff

netlify[bot] commented 1 month ago

Deploy Preview for wai-aria ready!

Name Link
Latest commit 32e060860fb15b29dee803667b198e095af35a67
Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/67069cb8cf16df0009437f36
Deploy Preview https://deploy-preview-2341--wai-aria.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

scottaohara commented 1 month ago

talking with @aleventhal about this some more, we should also add in what to do about if someone uses the empty string, or puts in literal "garbage" text strings.

So this can probably be positive full numbers works as presently spec'd 0 and any negative number == indeterminate anything else == undefined and thus ignore.

aleventhal commented 1 month ago

So this can probably be positive full numbers works as presently spec'd 0 and any negative number == indeterminate anything else == undefined and thus ignore.

I know this is going to happen in a follow-up, but it's probably good if it's not too strict, e.g. spaces before and after the number are ok. I was going to do the following:

  1. Empty string or not present = undefined and thus ignore
  2. Pass it to a non-strict int conversion function, and comes back < 1, treat as follows:
    • aria-posinset or aria-level -> 1
    • aria-setsize -> -1 (indeterminate)