Closed slawr closed 7 months ago
@petervolvowinz can you have a look at this?
Should already be fixed. Skickat från min iPhone
10 dec. 2023 kl. 4:33 em skrev Ulf Björkengren @.***>:
@petervolvowinzhttps://github.com/petervolvowinz can you have a look at this?
— Reply to this email directly, view it on GitHubhttps://github.com/w3c/automotive-viss2/issues/88#issuecomment-1848997564, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANIH3STLEBUAZXHHE6LQLCTYIXI57AVCNFSM6AAAAABANDX6AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYHE4TONJWGQ. You are receiving this because you were mentioned.Message ID: @.***>
Ok, will add documentation. The Access Token server is depending on the generated AGT servers public key. These are generated by the AGT application if not present. The file is "manually" copied to the viss servers' docker build. I will make a note of this for now.
OK, close this one.
Hi, great turnaround time on the issues I raised Friday. Thanks.
Phase 1 for the Playground is to create a PoC to allow the participants to understand the components and to build better in follow on phases. So looking at #91 and the readme description of AGT stating its role in offboard access control it seems in the short term at least the way to go would be to fork the WAII Dockerfile and comment out the key copy. Would you agree?
I see this issue has been closed. How will we track the task to fix the key generation for docker deployment or am I missing something in #91 that addresses it?
Yes, I agree.
I am currently doing an investigation on Access control and will be running this with Docker on a piece of hw in-vehicle, so I have been adding stuff just to get it running. Access control should come as a next step, like “ btw if you do this you can have a role based access control, do this…blab la ”. To get people interested I think it just complicate things. . Br Peter W
From: Stephen Lawrence @.> Date: Monday, December 11, 2023 at 12:46 PM To: w3c/automotive-viss2 @.> Cc: Winzell, Peter @.>, State change @.> Subject: Re: [w3c/automotive-viss2] dockerfile: build fails due to missing agt_public_key file (Issue #88)
Hi, great turnaround time on the issues I raised Friday.
Phase 1 for the Playgroundhttps://wiki.covesa.global/display/WIK4/Central+Data+Service+Playground?src=sidebar is to create a PoC to allow the participants to understand the components and to build better in follow on phases. So looking at #91https://github.com/w3c/automotive-viss2/pull/91 and the readme description of AGT stating its role in offboard access control it seems in the short term at least the way to go would be to fork the WAII Dockerfile and comment out the key copy. Would you agree?
I see this issue has been closed. How will we track the task to fix the key generation for docker deployment or am I missing something in #91https://github.com/w3c/automotive-viss2/pull/91 that addresses it?
— Reply to this email directly, view it on GitHubhttps://github.com/w3c/automotive-viss2/issues/88#issuecomment-1849909233, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANIH3SSETISMXCZBNBBEHDTYI3XA3AVCNFSM6AAAAABANDX6AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZHEYDSMRTGM. You are receiving this because you modified the open/close state.Message ID: @.***>
Yeah I was tempted to fudge the keys but then started to wonder if it might quickly become a barrier if people were trying to connect clients in a simple way early on and were getting access issues. Hence my thought about disabling.
OK I'll do that then. I'll comment out the key copy in the Dockerfile in the short term. That's an easy rebase if the upstream changes.
Just my opinion, but if this ticket remains closed I would suggest adding something to the task backlog (github issue or whatever the project is using for proj mgt) to address making that part of the Dockerfile optional. In part because the current default leads to a build error. I would be happy to try and contribute to that in the new year. I would have done something here but I'm time constrained this week and I don't fully understand the implementation picture it should fit into. Docker profiles could be used for example to control it.
Anyway thanks for the help in keeping me moving.
Summary
Dockerfile fails to build due to missing agt_public_key file.
Source: https://github.com/w3c/automotive-viss2/blob/852b779dfd8ff552f8e2b5cc96cac4472ba85fe4/Dockerfile#L82
Example failure:
Notes
Search of source https://github.com/search?q=repo%3Aw3c%2Fautomotive-viss2%20agt_public_key&type=code results in some references to directory in which it resides and the following tutorial note: https://github.com/w3c/automotive-viss2/blob/852b779dfd8ff552f8e2b5cc96cac4472ba85fe4/tutorial/content/peripheral-components/_index.md?plain=1#L25
Have not found documentation for generating it in a Docker build context or how to do it manually as a workaround.