Create a test as a reference implementation

w3c / baggage

Propagation format for distributed context: Baggage

https://w3c.github.io/baggage/

Other

47 stars 18 forks source link

Create a test as a reference implementation #74

Closed kalyanaj closed 2 years ago

kalyanaj commented 3 years ago

Similar to what was done for trace context, we need to create a test to serve as a reference implementation (correctness is the key goal and not necessarily a performant implementation).

srikanthccv commented 2 years ago

I was exactly looking for this to find what is language client implementation expected do in the case of certain cases

If number of baggage entries in the header exceed the maximum number of allowed entries, do we drop everything or do we drop extra entries and propagate the remaining entries?
If a baggage entry is invalid as per the definition, do we drop entire baggage or just that one entry?

This is not clear from spec. I would really appreciate some clarification here.

Thanks

kalyanaj commented 2 years ago

@lonewolf3739, thanks for your feedback, and my apologies on the delay in getting back. We have addressed the above questions in this PR: https://github.com/w3c/baggage/pull/82. Please let me know if this clarifies what you were looking for.

dyladan commented 2 years ago

I am also working on a test suite