search

w3c / baggage

Propagation format for distributed context: Baggage
https://w3c.github.io/baggage/
Other
48 stars 18 forks source link

Need to have concrete ABNF syntax #8

Closed reyang closed 4 years ago

reyang commented 5 years ago

We need to define the header format using ABNF, as what we've done for tracecontext https://github.com/w3c/trace-context/blob/master/spec/20-http_header_format.md#field-value

reyang commented 5 years ago

@SergeyKanzhelev I can work on the ABNF if you need my help.

lmolkova commented 5 years ago

More to this: spec suggest that correlation context is Url encoded string.

It means that all separator allowed by HTTP spec in header value will be escaped including separators spec defines (. ,, ; and =): e.g. name1=value1;properties1,name2=value2;properties2 looks like name1%3Dvalue1%3Bproperties1%2Cname2%3Dvalue2%3Bproperties2

Besides being not readable, it also seems to break comma-separated multiple header fields behavior defined by HTTP.

We can say that keys, values, and properties have to be url encoded separately or find other ways to keep correlation-context values compliant with HTTP header values.

yurishkuro commented 4 years ago

@lmolkova your comment is already addressed (doesn't really belong to this issue).

Otherwise the format is already defined via ABNF, so closing this issue.