w3c / beacon

Beacon
https://w3c.github.io/beacon/
Other
47 stars 22 forks source link

credentials "omit" needs to be changed updated #1

Closed plehegar closed 9 years ago

plehegar commented 9 years ago

[[ We should set the "Content-Type" header as an author header, and the "omit" credentials mode" flag to "never" when invoking the fetch algorithm. ]] http://lists.w3.org/Archives/Public/public-web-perf/2014Feb/0025.html

sicking commented 9 years ago

I thought we had agreed to always send cookies with beacons?

plehegar commented 9 years ago

The spec says "omit" at the moment, and Arvind was wondering about it: [[ Re. the "credentials mode" parameter in the Fetch request, currently we have it set to "omit". What should it be instead of that? ]] http://lists.w3.org/Archives/Public/public-web-perf/2014Aug/0046.html

So, I guess the value needs to be "include", correct?

sicking commented 9 years ago

It should be "include" yes.

plehegar commented 9 years ago

Thank you Jonas. Arvind, I'm happy to make the change if you'd like me to.

jainarvind commented 9 years ago

Thanks Jonas and Philippe. Please go ahead and make the change.

On Wed, Oct 8, 2014 at 3:50 PM, Philippe Le Hegaret < notifications@github.com> wrote:

Thank you Jonas. Arvind, I'm happy to make the change if you'd like me to.

— Reply to this email directly or view it on GitHub https://github.com/w3c/beacon/issues/1#issuecomment-58440647.