search

w3c / beacon

Beacon
https://w3c.github.io/beacon/
Other
46 stars 22 forks source link

Tests for CORS and sendBeacon() #41

Closed annevk closed 6 years ago

annevk commented 7 years ago

I'd like to see tests for https://github.com/w3c/beacon/commit/8a6fbdca25115aa5a66c32cfc37d4882384b3398 and bugs filed against browsers. It's important to make sure that's all implemented correctly.

If for some reason this needs to change, please escalate to Fetch.

toddreifsteck commented 6 years ago

See https://github.com/w3c/web-platform-tests/pull/6655

@igrigorik

igrigorik commented 6 years ago

@toddreifsteck @Brandr0id thanks for the PR -- great work there!

Left a question for CORS bits: https://github.com/w3c/web-platform-tests/pull/6655#pullrequestreview-53913059

igrigorik commented 6 years ago

As an update, we landed https://github.com/w3c/web-platform-tests/pull/6655 -- big thanks to @Brandr0id and @toddreifsteck for contributing those tests!

Re, CORS: as noted in https://github.com/w3c/web-platform-tests/pull/6655#pullrequestreview-56253846, we still need to wire up some CORS tests for non-safelisted payloads, hence keeping this open.

igrigorik commented 6 years ago

@Brandr0id any luck on your end, for the CORS bits? :)

toddreifsteck commented 6 years ago

Resolved by https://github.com/w3c/web-platform-tests/pull/8757