Closed zurmuehl closed 6 years ago
Thanks! fixed.
Thanks for the fast fix! Unfortunately there are 3 other places where 'visibilityState' is misspelled as 'visiblityState':
Oh, @zurmuehl can you be a hero and send a pull request for them? I just did the edit directly on github.
No, I've not fixed them yet :) Only one.
On April 23, 2018 at 9:43:33 PM, Martin Zurmuehl (notifications@github.com) wrote:
Hi Marcos,
I have reported 3 additional tyes in #61. Have you already fixed them too? So far I didn’t see them on github. After you fixed them I will crated a pull request. Rookie question: What are the correct base branch and head branch for the pull request?
Thanks Martin
From: Marcos Cáceres [mailto:notifications@github.com] Sent: Montag, 23. April 2018 13:14 To: w3c/beacon Cc: Zurmuehl, Martin ; Mention Subject: Re: [w3c/beacon] Typo in Example 1 code (#61)
Oh, @zurmuehl can you be a hero and send a pull request for them? I just did the edit directly on github.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/w3c/beacon/issues/61#issuecomment-383546452
Pull request created.
In the beacon spec. in the introduction section in example 1 the coding line if (document.visiblityState === 'hidden') contains a typo: visiblityState should read visibilityState