w3c / bp-i18n-specdev

Internationalization Best Practices for Spec Developers
https://w3c.github.io/bp-i18n-specdev/
Other
22 stars 24 forks source link

Mention combining characters in the template #104

Closed xfq closed 7 months ago

xfq commented 1 year ago

Fix #103.


Preview | Diff

netlify[bot] commented 1 year ago

Deploy Preview for bp-i18n-specdev ready!

Name Link
Latest commit 2802f58e8f8f07979877352bf4753f11b250f2ab
Latest deploy log https://app.netlify.com/sites/bp-i18n-specdev/deploys/64785c67e3c7f00008474dd6
Deploy Preview https://deploy-preview-104--bp-i18n-specdev.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

aphillips commented 11 months ago

I think we should abandon this PR, since we now have guidance on using images.

xfq commented 11 months ago

The current text says "For invisible characters (such as control characters) or for whitespace, use an image instead of the character", but does not mention combining characters. I think we should add that.

By the way, I think whitespace are also "invisible", and some of them are also control characters.

r12a commented 11 months ago

The combining characters often work ok without the need for images. If the font behaves well, it will typically add a dotted circle when displaying isolated combining marks. So an image is only needed sometimes.

aphillips commented 7 months ago

Any update? Should we keep this or abandon?

xfq commented 7 months ago

I still think it's useful to mention combining characters in the template. Since there are merge conflicts, I will close this PR and craft a new one.

xfq commented 7 months ago

The combining characters often work ok without the need for images. If the font behaves well, it will typically add a dotted circle when displaying isolated combining marks. So an image is only needed sometimes.

I found that the font didn't behave well on my system (without changing any font-related preferences), so it may appear for other users as well. Maybe we should use images?


Screenshot:

Screenshot 2023-12-19 at 10 59 05

It's Chrome 120 on macOS 14.2. The rendered font seems to be Hiragino Sans.