search

w3c / bp-i18n-specdev

Internationalization Best Practices for Spec Developers
https://w3c.github.io/bp-i18n-specdev/
Other
22 stars 24 forks source link

Mirror tr-design changes and update specdev markup #113

Closed aphillips closed 10 months ago

aphillips commented 11 months ago

Preview | Diff

netlify[bot] commented 11 months ago

Deploy Preview for bp-i18n-specdev ready!

Name Link
Latest commit 4bdcdb57173f17b7c2abb7de09f4dfd81ff21dbd
Latest deploy log https://app.netlify.com/sites/bp-i18n-specdev/deploys/64d503e4b1243000093e678c
Deploy Preview https://deploy-preview-113--bp-i18n-specdev.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aphillips commented 11 months ago

@r12a

One observation: should we recommend what to put into the alt for an img? In our example we put "NBSP" for the no-break space, but that's kind of a special case.

Also... do we want to image-ize invisibles mentioned in specdev? ("this dog food is yummy")

This PR changes span to code, but very little (nothing?) in the actual text about styling templates is modified here.

r12a commented 11 months ago

I think they can probably figure out what they want to put in the alt text. Usually, if it's not an invisible character i put the character itself, but i'm not sure we need to recommend that.

I agree that we should imagize the invisibles in specdev.

r12a commented 11 months ago

I made a comment somewhere about recommending that authors style the bdi character(s) for font-family & font-size, which i imagine applies to these changes too.

aphillips commented 11 months ago

I agree that we should imagize the invisibles in specdev.

The list is not as short as one might like 😉 but I will pull one together. If you (@r12a) could generate the images, I'd appreciate it. I think I'll make a separate task out of that...

r12a commented 11 months ago

I took one last look at the generated version. The proposed changes look ok. However, i noticed 2 things:

  1. there is no mustard
  2. the "see also" box is normally reserved for links to other sections within the document. External links appear either in the blocks entitled "Useful background and overviews for this section" or in the pulldowns below the mustard.