search

w3c / bp-i18n-specdev

Internationalization Best Practices for Spec Developers
https://w3c.github.io/bp-i18n-specdev/
Other
24 stars 24 forks source link

Change character styling template to use `brown` #97

Closed aphillips closed 1 year ago

aphillips commented 1 year ago

Note well: the preview doesn't currently work because of how we import local.css

netlify[bot] commented 1 year ago

Deploy Preview for bp-i18n-specdev ready!

Name Link
Latest commit e44176ec8f77d076e5806a2a4c847c0887daa1b9
Latest deploy log https://app.netlify.com/sites/bp-i18n-specdev/deploys/644b7b7ec5b35a000834000b
Deploy Preview https://deploy-preview-97--bp-i18n-specdev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

xfq commented 1 year ago

The change looks good to me.

About the preview, if we import CSS in this way, there will be no way to preview all our changes to the CSS file in the future. Is this what we want?

aphillips commented 1 year ago

@xfq I don't think this is what we want, except that it made publishing through echidna much easier. I'm going to add some JS when I get some time to get the best of both worlds.