w3c / clreq

Requirements for Chinese Text Layout
https://www.w3.org/International/clreq/
Other
728 stars 61 forks source link

"Former editors" in the Chinese version is unchanged #329

Closed xfq closed 4 years ago

xfq commented 4 years ago

After clicking 简体中文 or 繁體中文, the "Former editors:" header remains unchanged while other headers do change to Chinese. Not sure why...

/cc @r12a

himorin commented 4 years ago

script.js line 138, var originalText = $dt.dataset.originalText || $dt.textContent should be var originalText = $dt.dataset.originalText || $dt.innerText?

himorin commented 4 years ago

sorry. no.. use $dt.textContent.trim() should be better...

xfq commented 4 years ago

Thanks for the hint @himorin - you are right indeed.

xfq commented 4 years ago

Fixed in https://github.com/w3c/clreq/commit/c545424c6829da35c819f851e8f347fd91e75aea