search

w3c / controller-document

Controller Documents
https://w3c.github.io/controller-document/
Other
5 stars 5 forks source link

Context injection description favors Data Integrity securing method over JOSE COSE securing method #70

Open selfissued opened 2 weeks ago

selfissued commented 2 weeks ago

https://www.w3.org/TR/2024/WD-controller-document-20240817/#context-injection The sentence "If an @context property is not provided in a document that is being secured or verified, or the Data Integrity terms used in the document are not mapped by existing values in the @context property, implementations MUST inject or add an @context property with a value of https://w3id.org/security/data-integrity/v2." assumes that Data Integrity is being used. A premise of the Controller document work was that it would be securing method independent.

One of these actions needs to be taken to remediate this:

  1. This whole section should be removed, as suggested in #68,
  2. The text suggesting adding a data-integrity context value should be removed, or
  3. Equivalent text saying what to do instead when using jose-cose and JSON-LD needs to be added.
iherman commented 2 weeks ago

This issue should be closed if and when #68 is merged.

msporny commented 2 weeks ago

The URL is incorrect, if context injection is performed (which only happens if interpretation as JSON-LD), then the controller document context is injected. I can raise a PR to do that

selfissued commented 2 weeks ago

I agree that this is ready for a PR.

msporny commented 1 week ago

PR #90 has been raised to address this issue. This issue will be closed once PR #90 has been merged.

msporny commented 6 days ago

PR #90 has been closed in favor of PR #92, which has been raised to address this issue. This issue will be closed once PR #92 has been merged.