w3c / css-houdini-drafts

Mirror of https://hg.css-houdini.org/drafts
https://drafts.css-houdini.org/
Other
1.84k stars 141 forks source link

[CSS-Typed-OM] Change reifying as from 'a CSSStyleValue' to 'an identifier' #1068

Closed DevSDK closed 2 years ago

DevSDK commented 2 years ago

Step 2 of parse() [1] says "Reify a color value from result ".

However, "Reify a color value" algorithm [2] needs a second parameter,

which is a property to be consumed by step 9 only.

Therefore, Change step 9 from 'CSSStyleValue' to 'an identifier'[3] for reifying.

And the reify a color value algorithm no more need |prop|.

Hence, Remove the |prop| parameter of 'reifying a color value'.

[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-csscolorvalue-parse [2] https://drafts.css-houdini.org/css-typed-om-1/#reify-a-color-value [3] https://drafts.css-houdini.org/css-typed-om-1/#reify-an-identifier

Working Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/3522201 csswg issue: https://github.com/w3c/csswg-drafts/issues/7174 cc. @xiaochengh

xiaochengh commented 2 years ago

@tabatkins Could you ptal?