search

w3c / csswg-drafts

CSS Working Group Editor Drafts
https://drafts.csswg.org/
Other
4.52k stars 672 forks source link

[css-grid-3] Animation type of `masonry-slack` should be "by computed value" #10931

Open Loirooriol opened 2 months ago

Loirooriol commented 2 months ago

https://drafts.csswg.org/css-grid-3/#masonry-slack

Computed value: a computed <length-percentage> value Animation type: as length

How to interpolate as a length if the computed value is a <length-percentage>? It should interpolate "by computed value", that is, as defined in https://www.w3.org/TR/css-values-4/#combine-mixed

tabatkins commented 2 months ago

That had been fixed with the other things; possibly the build was out of date when you looked at it.

Loirooriol commented 2 months ago

This has not been fixed, I can see it in the source code of the current main: https://github.com/w3c/csswg-drafts/blob/0e5095c213d2b6a47a694890ae2cb37b1d86b568/css-grid-3/Overview.bs#L1067

fantasai commented 2 months ago

That raises the question: is there a reason to have percentages here? The original proposal didn't include them, and I think that's still the right call. (It would be pretty wild for an auto-sized masonry container!)

Loirooriol commented 2 months ago

I'm fine with restricting to lengths, as long as the computed value and the animation type are consistent.

Loirooriol commented 2 months ago

BTW, after #10883, both the computed value and the animation type need to handle infinite