w3c / csswg-drafts

CSS Working Group Editor Drafts
https://drafts.csswg.org/
Other
4.43k stars 656 forks source link

[css-values-3][spec-rec] Publish CSS Values & Units 3 as a REC #4846

Open gsnedders opened 4 years ago

gsnedders commented 4 years ago

From @atanassov's last email, given having something public to point at about what blocks publishing it would be nice:

AIUI the blockers status are:

svgeesus commented 4 years ago

Check test suite status and write an implementation report

The report is automatically generated. Here is the current one (39 of 70 required tests meet CR exit criteria).

The main things missing are passes on ch units in both horizontal and vertical writing.

There are also missing test results for Blink, Webkit (and also Edge, if anyone has a pre-Blink Edge around for testing)

svgeesus commented 4 years ago

Currently 6 open, 41 closed issues (one of them being this meta-issue).

gsnedders commented 4 years ago

The report is automatically generated. Here is the current one (39 of 70 required tests meet CR exit criteria).

Well, yes, but I've almost never seen an implementation report accepted without any sort of human-written element explaining failures. :)

Currently 6 open, 41 closed issues (one of them being this meta-issue).

FWIW, it wasn't clear how many of those are things that actually block Level 3?

gsnedders commented 4 years ago

and also Edge, if anyone has a pre-Blink Edge around for testing

https://wpt.fyi/results/css/css-values?label=master&product=edge-44.17763.1.0&product=chrome%5Bstable%5D&product=firefox%5Bstable%5D&product=safari%5Bstable%5D&aligned has results for 4b7986331d2e2ee1e63ed42e392d36946904327c, which is admittedly now a while ago.

svgeesus commented 4 years ago

Now 57 of 70 required tests meet CR exit criteria Problems are ch unit, especially in vertical writing; calc in transform; calc in offset-position, and calc in text-combine-upright: digits .

I suspect carefully checking the correctness of those tests, then filing individual bugs on browser engines, would help drive those fails towards zero.

And yes, a human-written addendum that the fails are more to do with the other specs being tested (this is particularly true with a spec like V&U) will be needed.

svgeesus commented 4 years ago

I removed the css-calues-3 tag on https://github.com/w3c/csswg-drafts/issues/4329 and the rest look like low-hanging fruit that could be closed off speedily.

svgeesus commented 4 years ago

[CSS-VALUES-4] (note this is a normative citation from level 3 to level 4!)

Okay that is a bit whacked.

 [css-values-4] defines the following terms:
%
angle
frequency
integer
length
number
string
time
toggle()
url 

I'm guessing that is incorrect bikeshed syntax, and should be fixed.

tabatkins commented 4 years ago

It can be fixed manually (using link-defaults), but the reason it's happening is that I currently only distinguish between "ED" and "TR" statuses for definitions; I don't go into more fine-grained divisions within TR. As such, Values 4 is considered a perfectly suitable definition source.

svgeesus commented 1 month ago

So (four years later):

Assessing the level of implementation support is tricky because the values and units can't be implemented by themselves; the actual WPT are examples where other specifications are using them. There is a manually generated implementation report but that was last updated April 2021.

@tabatkins @fantasai how close do you think this is to getting to REC? It would need another CR Snapshot first, of course.