w3c / csvw

Documents produced by the CSV on the Web Working Group
Other
163 stars 57 forks source link

Demonstrate independence of primaryKey, foreignKeys and urlTemplates #63

Closed JeniT closed 9 years ago

JeniT commented 9 years ago

See http://w3c.github.io/csvw/metadata/#examples - is this enough?

iherman commented 9 years ago

Hey Jeni

All in all, this seems to be pretty clear, thanks. Some comments/questions:

Thanks!

Ivan

P.S. More generally: with the url template mechanism we discussed at TPAC it is true, isn't it, that the primary keys do not play any role in the conversion algorithms?

On 26 Nov 2014, at 16:51 , Jeni Tennison notifications@github.com wrote:

See http://w3c.github.io/csvw/metadata/#examples - is this enough?

— Reply to this email directly or view it on GitHub.


Ivan Herman, W3C Digital Publishing Activity Lead Home: http://www.w3.org/People/Ivan/ mobile: +31-641044153 ORCID ID: http://orcid.org/0000-0003-0782-2704

6a6d74 commented 9 years ago

@JeniT: in your example 3.8.1.1 Foreign Key Reference Between Resources the primaryKey specified for resource https://example.org/countries.csv is country ... I can't see a column name country - is this a typo & it should be countryCode?

6a6d74 commented 9 years ago

@JeniT: in 3.8 Schemas your definition of foreignKey is:

""" An array of foreign key definitions that define how columns within this table link to columns within other tables. """

I wonder if the definition is more like:

""" An array of foreign key definitions that define how the values from specified columns within this table link to rows within the same table or other tables. """

Use Case #1 - Digital preservation of government records describes how foreign keys are used to reference rows (records) from within the same CSV file.

JeniT commented 9 years ago

@6a6d74 thanks, I've made those changes, although now I think about it, you're actually potentially linking from multiple columns, as in #66 - so will continue discussion about that there.

@iherman:

JeniT commented 9 years ago

The examples currently in the spec seem to have fulfilled the stated aim of this issue, so closing this, though others about primary keys & foreign key references such as #66 and #130 remain open.