Open nigelmegitt opened 2 years ago
Possibly an issue for a future discussion; not marking as Agenda today because there's not been enough discussion on this issue to warrant it.
Discussed 2023-02-09 with @cconcolato : Agreed to highlight this question somewhere in the specification so that when we go to FPWD we can ask for feedback from the wider world on how important it is to support partial editing.
Should we add a daptm:stage = draft | final
?
Maybe daptm:status = draft | final
but yes, that'd be okay by me. Orthogonal to the script type, i.e. it's reasonable to have a draft or a final version of each script type.
Hi - further to conversations with Nigel, we would suggest a means of tracking changes once something has been edited - so that a delta can readily be produced for reversioning (i.e. a list of points in a script or programme to review and chnage). Frequently the international release of content is tweaked (for music rights, unsuitable language etc) and it would be good to know which sections of the script have been modified. I don't think this needs to be word by word within the DAPT doc, but rather a means of flagging change on sections. Perhaps last modified date / time stamp, as that would allow iteration...?
See also #140.
The Timed Text Working Group just discussed Collaborative editing or partial editing - do we need "unfinished" state? w3c/dapt#52
, and agreed to the following:
SUMMARY: Continue discussing offline
Resolving this issue is important to resolve #75. For example, if we don't allow partial documents, there is no reason to have a document with 0 events.
Current spec says: https://w3c.github.io/dapt/#script-events
A DAPT Script MAY contain zero or more Script Event objects
A final document SHALL have at least one script event, otherwise the document seems useless.
Similarly, https://w3c.github.io/dapt/#dfn-script-event says:
A Script Event object [...] has the following properties: Zero or more Text objects [...]
A Script Event without Text in a final document does not make sense.
The concept of "final" is getting my brain in a twist. What's "final", i.e. deliverable, from one stage, may be merely an input to the next stage.
For example, if I'm some kind of audio description process stage 1 preparer, then my only job might be to identify times when audio descriptions could be present. My "final" output would be a bunch of Script Events with timing properties but no Text objects in them.
Looking back at the discussion, I wonder if different concepts are needed:
One suggestion for how to address the "final" comment is to allow for some external rule set to be defined, and then add a review that checks the document against that rule set.
For example, a rule set could be:
Then a review can be added that validates the document against that rule set, and adds an entry into the review history.
This all feels a bit beyond the "minimum viable" v1 to me, but I could be persuaded if people really want/need this.
To make this more concrete, I'm thinking of something like:
<head><metadata>
<daptm:revisionHistory>
<daptm:revision revision="1" revDate="2024-03-27T1549">
<daptm:revComment>Added Script Event times</daptm:revComment>
</daptm:revision>
<!-- more revisions here -->
</daptm:revisionHistory>
<daptm:reviewHistory>
<daptm:review review="1" revision="1" ruleSet="urn:identifying:ruleset" revDate="2024-03-27T1550" reviewStatus="changes_needed">
<daptm:revComment>Found a Script Event with unusual duration</daptm:revComment>
</daptm:review>
<!-- more reviews here -->
</daptm:reviewHistory>
</metadata></head>
<body>
<div xml:id="se1" revision="1" begin="0.1s" end="0.2s">
<metadata>
<daptm:reviewNote review="1">Short duration</daptm:reviewNote>
</metadata>
</div>
</body>
I think it's very hard to declare something to be final; only time indicates no further changes were made in my experience - otherwise it's just a version published on a give day. The revision approach suggested here, esp if applicable to the text itself, would be great for directing a revision / reversion process downstream (e.g. filter text by changes please), but I agree that to get this usable could take a bit of iteration and may make more sense once there are some 'real' files in existance.
We need think about either collaborative editing or partial editing and whether we need "unfinished" state. Worth an issue.
_Originally posted by @cconcolato in https://github.com/w3c/dapt/pull/49#discussion_r973503810_