nodeValidator-ask-001 and propertyValidator-ask-001 tests need revision

[jimkont]

nodeValidator-ask-001 and propertyValidator-ask-001 contain ill-formed SHACL graphs.

Both tests use a sh:propertyValidator and sh:nodeValidator with a sh:SPARQLAskValidator while this is not allowed in the spec:

• The values of sh:nodeValidator must be SELECT-based validators.
• The values of sh:propertyValidatormust be SELECT-based validators.
• The values of sh:validator must be ASK-based validators.

To fix the test cases, sh:propertyValidator and sh:nodeValidator need to be replaced with sh:validator or convert both validators to sh:SPARQLSelectValidator (with sh:select and a SELECT query)

It would be also good to keep a version of these tests that expects failure

[HolgerKnublauch]

There are two possibilities here: 1) Change the test cases to reflect what the spec says 2) Generalize the spec. I cannot judge on whether this is considered minor enough to be allowed here, but in my implementation I naturally assumed that ASK queries would also be permitted, and so did the other passing implementation.

I have no strong opinion at this stage, I guess it depends on how much we are allowed to change in the spec.

[jimkont]

I would be in favor of (1) but I do not have a strong opinion here either.

My rationale is that ASK queries hide the property/node shape SPARQL BGPs from the user and could run from both a node and a shape validator. This is not the case with SELECT queries where people need to specify exactly the validator they need. With this in mind, I find the current definition more intuitive and less error-prone.

What would be the process for deciding this? I can volunteer to create a pull request with the adjusted tests if you give me a go

On Thu, Oct 19, 2017 at 4:22 AM, Holger Knublauch notifications@github.com wrote:

There are two possibilities here:

1. Change the test cases to reflect what the spec says
2. Generalize the spec. I cannot judge on whether this is considered minor enough to be allowed here, but in my implementation I naturally assumed that ASK queries would also be permitted, and so did the other passing implementation.

I have no strong opinion at this stage, I guess it depends on how much we are allowed to change in the spec.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/w3c/data-shapes/issues/96#issuecomment-337772363, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_8HfNNpRZt74TeYBQTrVE5DI-xaCSwks5stqQ8gaJpZM4P953d .

-- Kontokostas Dimitris

[HolgerKnublauch]

Yes for now I assume we should do (1) as a fix to the mismatch. Probably just delete the tests? Go ahead with a PR if you have time.