search

w3c / device-posture

Device Posture API
https://www.w3.org/TR/device-posture/
Other
33 stars 21 forks source link

Rename "posture modes" to "posture types" #64

Closed beaufortfrancois closed 3 years ago

beaufortfrancois commented 3 years ago

As the DevicePosture interface has now a member called type, we may want to rename posture modes to "posture types" for consistency. What do you folks think about it?

interface DevicePosture : EventTarget {
  readonly attribute DevicePostureType type;
  ...
};
anssiko commented 3 years ago

I think this was addressed by https://github.com/w3c/device-posture/pull/65/ (thanks @beaufortfrancois for that PR!).

beaufortfrancois commented 3 years ago

It was not addressed by #65. This issue is about renaming the "posture modes" in https://w3c.github.io/device-posture/#posture-modes to "posture types".

anssiko commented 3 years ago

Sorry for being trigger-happy, reopened.

darktears commented 3 years ago

I don't have a strong preference but if we were to be consistent, we should use "modes" in my opinion. Samsung and other folks have been using terms like "tent mode" or "flex mode" and I regularly hear people saying "being used as laptop mode".

kenchris commented 3 years ago

I think it should be Type as it's an enum. Would be consistent with Orientation lock spec