w3c / deviceorientation

W3C Device Orientation spec
https://www.w3.org/TR/orientation-event/
Other
49 stars 32 forks source link

Add Security and Privacy Self-Review Questionnaire #126

Closed anssiko closed 8 months ago

anssiko commented 10 months ago

This is a prerequisite for Privacy and Security reviews: https://www.w3.org/Guide/documentreview/#how_to_get_horizontal_review

@rakuco @reillyeon given you're on top of this specification I'm expecting you to help fill in this questionnaire. I pre-populated this doc with some content to help get the work started. I don't claim those responses to be complete or even accurate so I seek your expert review. Thank you for your contributions.

125 is complementary material to help guide reviewers. I acknowledge that this specification last time reached its CR maturity in 2016 and at that time this self-assessment was not required, and we don't have a prior record. However, we have completed these reviews and done self-assessment for the Generic Sensor family of specs in 2018 which can be reused for its applicable parts for this review. I provided links to those self-assessments in this doc.

anssiko commented 9 months ago

Much thanks @reillyeon for your contributions.

This PR welcomes further review and contributions from other interested contributors with an understanding the holiday season is about to start. Thus I'd propose we don't rush this and revisit in January.

anssiko commented 9 months ago

@rakuco PTAL at your convenience.

anssiko commented 8 months ago

@lknik @maryammjd @toreini we acknowledge your deep domain expertise could help further improve this self-assessment response before we ship it to the Privacy Interest Group for review. You are of course welcome to provide your feedback also through the PING review mechanism. Thank you for your contributions that enable the WG to deliver privacy-preserving Web APIs.

lknik commented 8 months ago

Update 2.11 in Security and Privacy Self-Review Questionnaire

@anssiko

Looks good to me. I'd just wonder about "Minor manufacturing imperfections and differences unique to the underlying platform and the sensor hardware in the hosting device can be detected through readings over time."

Is it really possible with reduced precision? Perhaps change from "can be" to "might be"?

anssiko commented 8 months ago

Perhaps change from "can be" to "might be"?

@lknik thanks, that is a better wording for this. Updated the PR in https://github.com/w3c/deviceorientation/pull/126/commits/f9c6e3a862b2cc65efb5d766c236d538da00189c

toreini commented 8 months ago

Hi Anssi, I read through the document. It generally looks fine to me. One item that I think could be mentioned is the communication channel in 2.3. As it contains PII data a mention of that could help, something like -> a secure communication channel is recommended.

If you think it is too obvious to mention, leave it though.

Cheers, Ehsan

anssiko commented 8 months ago

@toreini thanks for your feedback. Your suggestion has been incorporated. I reworded it slightly, see https://github.com/w3c/deviceorientation/pull/126/commits/50ab599e9ece990d9cb7ae6c07a752db5aeaf8dd

See also https://www.w3.org/TR/security-privacy-questionnaire/#secure-contexts

toreini commented 8 months ago

Thanks @anssiko ! Yes, I know this exists, but thought it would clarify better if reiterated in the questionnaire. :)

anssiko commented 8 months ago

With review from multiple WG participants, including the WG's privacy domain experts (thanks @lknik @toreini!), I consider this PR is ready to be merged.

I expect us to continue refine this doc based on review feedback from TAG, PING and Security reviewers. Further contributions are welcome via new PRs.