search

w3c / deviceorientation

W3C Device Orientation spec
https://www.w3.org/TR/orientation-event/
Other
49 stars 32 forks source link

Update status of this document #142

Closed anssiko closed 8 months ago

anssiko commented 8 months ago

For CR publication purposes.

Preview | Diff

anssiko commented 8 months ago

Note: @himorin we'll need to add new bikeshed-boilerplate files to recognize this as a joint publication.

himorin commented 8 months ago

Note: @himorin we'll need to add new bikeshed-boilerplate files to recognize this as a joint publication.

you just need to do the same thing as contact-picker

text macro: JOINT yes text macro: JOINTWEBAPPS yes

note, I realized that I need to update text related to Process dated version...

anssiko commented 8 months ago

@himorin thanks, I pushed an update with these macros in https://github.com/w3c/deviceorientation/pull/142/commits/ec093c26671f32ae56f31c2ef057a80065034535

himorin commented 8 months ago

note, ED boilerplate does not have joint deliverable line for document has produced by.

anssiko commented 8 months ago

Thanks @himorin! I pushed https://github.com/w3c/deviceorientation/pull/142/commits/380c6ce2268ea685b56702b326aef3be83b54782 to include the Implementation Report header.

anssiko commented 8 months ago

Thanks for your review folks. I pushed an update to address the remaining comments. TAG folks appreciated the history lesson and the high-level summary, so I recommend we keep it.

PTAL @reillyeon @marcoscaceres @himorin

I noticed @himorin's build pulled the PR entrance / CR exit criteria from the bikeshed boilerplate file (status-CR.include) so I removed the similar text from this PR to not duplicate it. There's still a minor imperfection in that it says "Working Group", while it should say "Working Groups" or "Working Group(s)". I'll let @himorin handle those tweaks to the bikeshed boilerplate files.

@himorin this PR should be good to merge. Please verify it builds with your CR config. Let us know if you spot any other bugs.

reillyeon commented 8 months ago

I filed https://github.com/w3c/deviceorientation/issues/145 to track the follow-up issues @himorin is working on.

himorin commented 8 months ago

I noticed @himorin's build pulled the PR entrance / CR exit criteria from the bikeshed boilerplate file (status-CR.include) so I removed the similar text from this PR to not duplicate it. There's still a minor imperfection in that it says "Working Group", while it should say "Working Groups" or "Working Group(s)". I'll let @himorin handle those tweaks to the bikeshed boilerplate files.

Ahh,, yes. Also do we want to include mail lists of both WebApps and DAS into feedback section? (I'm not sure what we can do on this front, although.. - We could update SoTD part to include both, since it's just a text part of boilerplate) For "Working Group", if "Working Group(s)" is ok, it helps editing much, since there are three in text which does not have any other change from 'joint'. I'll push PR to boilerplate repository shortly.

@himorin this PR should be good to merge. Please verify it builds with your CR config. Let us know if you spot any other bugs.

please check updated build also. this uses diff to this sotd branch as

-Status: ED
+Status: CR
+Date: 2024-03-20
+Deadline: 2024-04-17
anssiko commented 8 months ago

@himorin these text macros:

text macro: JOINT yes text macro: JOINTWEBAPPS yes

Seem to cause a "deliverer-changed" error in echidna, see https://labs.w3.org/echidna/api/status?id=5094fa41-b80c-460a-8a46-c6f2c2c8db72 and look into a fix.

himorin commented 8 months ago

@anssiko this is not an error from bikeshed, but is from a change on spec metadata - single WG publication to joint publication. We should publish this via manual publication with asking publication metadata change. I suppose there was some conclusion of CfC on switching into joint publication, but I could not find one. Could you point something like in mail list archive?

anssiko commented 8 months ago

@himorin thanks for debugging this. I followed up on the CfC topic via mail.