w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
407 stars 96 forks source link

Replace "service endpoint" with "service" where appropriate. #564

Closed peacekeeper closed 3 years ago

peacekeeper commented 3 years ago

I feel like we're saying "service endpoint" in a lot of places where we should be saying "service". A service may or may not have a service endpoint.

EDIT: The second sentence above is wrong; see discussion below.


Preview | Diff

rhiaro commented 3 years ago

service may or may not have a service endpoint.

Clarification - the spec says:

Each service endpoint MUST have id, type, and serviceEndpoint properties

Is this not the case, and serviceEndpoint is in fact optional?

iherman commented 3 years ago

service may or may not have a service endpoint.

Clarification - the spec says:

Each service endpoint MUST have id, type, and serviceEndpoint properties

Is this not the case, and serviceEndpoint is in fact optional?

That is clearly incorrect somewhere... In my view serviceEndpoint should be required (as the table shows). This is the only distinctive feature of a service at the moment...

peacekeeper commented 3 years ago

Each service endpoint MUST have id, type, and serviceEndpoint properties

You are all correct, sorry, my mistake! I think it doesn't affect this PR though.

msporny commented 3 years ago

Editorial, multiple reviews, no objections, merging.