search

w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
405 stars 94 forks source link

Various cleanups. #633

Closed davidlehn closed 3 years ago

davidlehn commented 3 years ago

Preview | Diff

msporny commented 3 years ago

@davidlehn -- due to the massive editorial pass that's happening on the specification right now (expected to be done close to the end of this week), this PR is bound to have/create lots of merge conflicts. I'm going to hold off on merging it until the editorial pass has been completed.

Also, if you want your full commit history to be saved, please specify which section you're applying changes to. "Fix typos." and "Add missing link." is not descriptive enough -- and the Editors depend on these comments when trying to track down where changes happened. :)

msporny commented 3 years ago

@davidlehn -- ok, NOW is the right time to make this pass. Can you please make it again... don't know if this PR is salvageable. Please close it if it isn't.

peacekeeper commented 3 years ago

I also thought it would be best to do these tiny spelling and formatting fixes at the very end to avoid merge conflicts. But having said that, thanks a lot for spending the time to read through everything in such detail!

msporny commented 3 years ago

@davidlehn -- I have to make a snapshot of the spec for the transition to Candidate Recommendation, and all PRs must be processed by that time. If I don't hear back from you in 48 hours, I'm going to close this PR due to the merge conflicts. Please respond.

davidlehn commented 3 years ago

@msporny Rebased. That was a bit painful! I think all the fixes got through. Found a few more with all the new updates.

@peacekeeper Yeah, I had some poor timing with this PR. Oops. Mostly just use vim spellcheck (with some handholding), other vim markup checking, vim grammar(ish) checker, tidy, and some visual indent wrangling. Doesn't take all that long to do a pass every so often. Took longer to fix the rebase than to do the original edits!

msporny commented 3 years ago

Editorial, multiple reviews, changes requested and made, no objections, merging.