w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
405 stars 94 forks source link

Fix editorial issues with Capability Invocation section. #640

Closed msporny closed 3 years ago

msporny commented 3 years ago

Preview | Diff

peacekeeper commented 3 years ago

I like the changes, but maybe it would be sufficient and more readable to have the example use case (access to protected HTTP API via capabilities) in one place rather than two places (here and in https://github.com/w3c/did-core/pull/641). There seems to be some overlap and duplication.

Maybe it's better to consolidate and have a single example that describes both capabilityInvocation and capabilityDelegation simulataneously?

msporny commented 3 years ago

I like the changes, but maybe it would be sufficient and more readable to have the example use case (access to protected HTTP API via capabilities) in one place rather than two places (here and in #641). There seems to be some overlap and duplication. Maybe it's better to consolidate and have a single example that describes both capabilityInvocation and capabilityDelegation simulataneously?

Yes, I tried combining the Capability section and it became a bit large, so decided to keep it separate. We can try to do some more editorial cleanup after this PR is in.

msporny commented 3 years ago

Editorial, multiple reviews, changes requested and made, no objections, merging.