search

w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
404 stars 94 forks source link

Restore example of 'service' and 'relativeRef' parameters. #657

Closed peacekeeper closed 3 years ago

peacekeeper commented 3 years ago

https://github.com/w3c/did-core/pull/627 removed an example of a DID URL with a service parameter. I think it would be helpful to have such an example, so this PR adds one again.

Preview | Diff

peacekeeper commented 3 years ago

@msporny These parameters are both in DID Core and in the DID Spec Registries. I just created this PR to update to camelCase in the registries: https://github.com/w3c/did-spec-registries/pull/256

msporny commented 3 years ago

@msporny These parameters are both in DID Core and in the DID Spec Registries. I just created this PR to update to camelCase in the registries: w3c/did-spec-registries#256

Ah, sorry, I was speaking about the "agent" service parameter... which is strange... it threw me -- I thought were were assuming that there was a service specification for "agent"... but all this example is really showing is a relative reference for a URL. Could we change it to something like service=website&relativeRef=/credentials?

Using agent might throw people, like it did me -- I was assuming the relativeRef had to do with some sort of agent protocol. I'd be +1 to a service id that didn't imply a complex agent protocol.

peacekeeper commented 3 years ago

Fine with the change. Note that we also have an example in the DID Spec Registries at https://w3c.github.io/did-spec-registries/#relativeRef-param:

did:example:123?service=files&relativeRef=%2Fmyresume%2Fdoc%3Fversion%3Dlatest%23intro

msporny commented 3 years ago

Fine with the change. Note that we also have an example in the DID Spec Registries at https://w3c.github.io/did-spec-registries/#relativeRef-param:

did:example:123?service=files&relativeRef=%2Fmyresume%2Fdoc%3Fversion%3Dlatest%23intro

I simplified the example to a files service and a resume.pdf file.

msporny commented 3 years ago

Editorial, multiple reviews, changes requested and made, no objections, merging.