search

w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
404 stars 94 forks source link

What is the non empty value didResolutionMetadata when `resolve` is called #689

Closed OR13 closed 3 years ago

OR13 commented 3 years ago
Screen Shot 2021-02-20 at 3 55 51 PM

This seems like a mistake... its not like you know the contentType of an Abstract Data Model did document....

OR13 commented 3 years ago

@peacekeeper @jricher @msporny

msporny commented 3 years ago

This seems like a mistake.

Nice catch, I agree; that's a bug. I believe this is a hold over from the original write up from @peacekeeper and @jricher -- defer to them to note what's going on in that text.

peacekeeper commented 3 years ago

I agree this feels like a bug. Looks like this was introduced in https://github.com/w3c/did-core/commit/6cb86a38.

I suspect this was meant to say "... in the case of an error in the resolution process, this MUST NOT be empty."

(This would be parallel to the language about dereferencingMetadata in https://w3c.github.io/did-core/#did-url-dereferencing).

@jricher do you agree?

peacekeeper commented 3 years ago

I believe this has been fixed by https://github.com/w3c/did-core/pull/696 and can be closed. @OR13 do you agree?

msporny commented 3 years ago

PR #696 has been merged, waiting on confirmation from @OR13 to close.

OR13 commented 3 years ago

yes, this can be closed.