Closed iherman closed 3 years ago
The red label (and to a lesser extent, the red box) feels like a warning. Could that maybe be a deep green?
The red label (and to a lesser extent, the red box) feels like a warning. Could that maybe be a deep green?
I am fine with this, I think it is a good idea.
(Collecting comments before effectively doing this, though)
Happy for @iherman to "own" this diagram going forward. For reference, here is the source file of my original version:
I'm planning to work on updating https://github.com/w3c/did-core/pull/596 and https://github.com/w3c/did-core/pull/597.
Suggestions:
Just for consistency...
I have just made some adjustments on the diagram, mainly following the comments of @peacekeeper and @TallTed. Here is how the updated figure looks like:
Editorial, multiple reviews, changes requested and made, no objections, merging.
As referred to in https://github.com/w3c/did-core/pull/596#issuecomment-783989033 and in https://github.com/w3c/did-core/pull/597#issuecomment-783991200, updating figure 3 (the diagram in the Data Model) to separate core properties and representation specific entries.
Because preview cannot present referenced images, here is the content of the file in PNG (the one in the spec is SVG):
I was not sure of all the labels; they are a mouthful on the diagram... But maybe it is o.k.