w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
398 stars 94 forks source link

When is the DID URI getting constructed #729

Closed Kalanamith closed 3 years ago

Kalanamith commented 3 years ago

It is unclear at which point the DID URI is created. Is after persisting the DID document?

msporny commented 3 years ago

It depends on the DID Method. For DID Methods that are derived from a public-private keypair, you could argue that the DID URI is created the moment the keypair is generated. For DID Methods where the identifier has no relation to the keypair, it's probably when the DID is registered on the Verifiable Data Registry (e.g., database, distributed ledger, etc.).

So, the answer is "it depends on the DID Method".

Do you think it would be helpful to have this clarified in the specification?

Kalanamith commented 3 years ago

HI @msporny Yes It will be super helpful to add this clarification in the specification. It will enable the readers to

peacekeeper commented 3 years ago

@Kalanamith I always found it most helpful to assume that the DID comes into existence after the "create" DID operation has been executed. This "create" operation abstracts away all the method-specific details.

It is true that sometimes the DID is already known once keys are generated, and before the DID document has been "persistent" or "registered", but in my mind those concepts should be considered intermediary steps that don't always exist the same way across all DID methods, and they are all part of the overall "create" DID operation.

So the universal, abstract way of thinking about it: "create DID and DID document" -> now you know the DID.

msporny commented 3 years ago

@Kalanamith wrote:

Yes It will be super helpful to add this clarification in the specification.

Ok, I will add a note to the specification explaining when a DID URI gets constructed and referring to the DID Method Create operation (as @peacekeeper mentioned).

talltree commented 3 years ago

@msporny Have you added that note? Can this issue be closed?

iherman commented 3 years ago

The issue was discussed in a meeting on 2021-05-25

View the transcript #### 3.6. When is the DID URI getting constructed _See github issue [#729](https://github.com/w3c/did-core/issues/729)._ **Manu Sporny:** this just requires me to write some text … if someone else wants to take a look at that, please do
iherman commented 3 years ago

The issue was discussed in a meeting on 2021-06-08

View the transcript #### 5.3. When is the DID URI getting constructed _See github issue [#729](https://github.com/w3c/did-core/issues/729)._ **Manu Sporny:** still waiting on me, easy one I just havne't done it **Brent Zundel:** next 625
msporny commented 3 years ago

PR #765 has been raised to address this issue. This issue will be closed once that PR is merged.

msporny commented 3 years ago

PR #765 has been merged. I'm noting that @Kalanamith gave the PR a :heart: and a :+1: noting his explicit approval that we have addressed his issue. Closing.