search

w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
395 stars 93 forks source link

add appendix text RE did subject change #755

Closed talltree closed 3 years ago

talltree commented 3 years ago

Signed-off-by: Drummond Reed drummond@connect.me

This addresses issue #718.

Preview | Diff

TallTed commented 3 years ago

My "at a time" suggestion was very off-the-cuff, and this segment of text would benefit from a bit more word-smithing, because as it stands (especially with that addition), it might be read to suggest that the URI of the DID Subject might change, and I don't believe that is what we mean to say; rather it's the meaning of the URI of the DID Subject that might change.

kdenhartog commented 3 years ago

After re-reading this text again, I'm fine with it as is. My interpretation originally was that this text doesn't align well, but I now understand it differently. This reads to me now that the first paragraph is about the capabilities of how the DID Document, DID, and DID Subject are technically related. The second paragraph focuses on pointing out that the meaning is update-able by referencing the other text in persistence which gets to the heart of #718

I'll leave my approval and no longer feel its necessary to update the text.

talltree commented 3 years ago

I felt that @dlongley 's suggestions helped clarify any potential misunderstandings, so I accepted both of them.

msporny commented 3 years ago

@talltree, merge conflicts, please fix.

talltree commented 3 years ago

@msporny I was very puzzled as to why there would be a merge conflict until I realized (with @brentzundel 's help) that it was simply that I contributed two new sections of the Appendix (in responses to issues #718 and #719), and because both appeared at the end of the current Appendix text, GitHub thought they were in conflict with each other. So it was a quick fix to accept both. Should be ready to merge now.

iherman commented 3 years ago

Administratively, this should not be merged until the CR snapshot is published (hopefully next Tuesday). Otherwise, we have to update the 'previous version' reference in the CR snapshot header (remember, merge means publishing a new version in /TR).

msporny commented 3 years ago

Editorial, multiple reviews, changes requested and made, no objections, merging.