search

w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
395 stars 93 forks source link

"id" property missing in examples #800

Open chrisiba opened 2 years ago

chrisiba commented 2 years ago

In Example 31 and Example 32 the id property in the root map as required for all DID Documents by the DID Document properties is missing.

talltree commented 2 years ago

I'm wondering if the authors of these examples were thinking that they represented only partial DID documents and thus they were only showing the relevant portions. @msporny? @peacekeeper?

In any case, given that the id property is required, I agree it would be best to include it in these examples.

msporny commented 2 years ago

I'm wondering if the authors of these examples were thinking that they represented only partial DID documents and thus they were only showing the relevant portions. @msporny? @peacekeeper?

I believe that these are @OR13's examples, they don't look like partial documents to me. We should add the id property to the examples. Ideally, before the document goes out to REC. Since all examples are Editorial, we can do this as soon as someone submits a PR.

OR13 commented 2 years ago

PR raised to address this issue here -- https://github.com/w3c/did-core/pull/801

peacekeeper commented 2 years ago

Agree, this was clearly just an oversight, and the id should be added to fix this.